[Sumover-dev] [svn commit] r3860 - common/trunk/src

[sumover-dev at cs.ucl.ac.uk]

Author: piers
Date: Wed Sep 13 14:16:51 2006
New Revision: 3860

Modified:
   common/trunk/src/mbus.c

Log:
Added additional comment explaining seqnum wrap control

Modified: common/trunk/src/mbus.c
==============================================================================
--- common/trunk/src/mbus.c	(original)
+++ common/trunk/src/mbus.c	Wed Sep 13 14:16:51 2006
@@ -305,7 +305,7 @@
  
 	mbus_validate(m);
 
-      *mb_bufpos = '\0';
+    *mb_bufpos = '\0';
 	assert((mb_bufpos - mb_buffer) < MBUS_BUF_SIZE);
 	assert(strlen(mb_buffer) < MBUS_BUF_SIZE);
 
@@ -430,7 +430,7 @@
 
 	gettimeofday(&curr_time, NULL);
 	if (curr_time.tv_sec - m->last_heartbeat.tv_sec >= interval) {
-            m->seqnum=(++m->seqnum)%999999;
+        m->seqnum=(++m->seqnum)%999999;
 	    mb_header(m->seqnum, curr_time, 'U', m->addr, "()", -1);
 		mb_add_command("mbus.hello", "");
 		mb_send(m);
@@ -699,7 +699,10 @@
 	curr->dest             = xstrdup(dest);
 	curr->retransmit_count = 0;
 	curr->message_size     = alen + 60 + strlen(dest) + strlen(m->addr);
-        m->seqnum	       = (++m->seqnum)%999999;
+    /* Wrap seqnum on 999999 - Keeping seqnum to 6 digits - which is assumed
+	 * to be the case for a few functions in mbus. Longer seqnum's led to 
+	 * memory errors and aborts() */
+	m->seqnum			   = (++m->seqnum)%999999;
 	curr->seqnum           = m->seqnum;
 	curr->reliable         = reliable;
 	curr->complete         = FALSE;