[Sumover-dev] Re: [Media Tools] #168: RAT Crashes when two differently encrypted sessions run on same address

[Media Tools]

#168: RAT Crashes when two differently encrypted sessions run on same address
---------------------+------------------------------------------------------
  Reporter:  piers   |       Owner:  piers 
      Type:  defect  |      Status:  closed
  Priority:  major   |   Milestone:        
 Component:  rat     |     Version:  4.3.00
Resolution:  fixed   |    Keywords:        
---------------------+------------------------------------------------------
Changes (by piers):

  * status:  new => closed
  * resolution:  => fixed

Comment:

 Fixed: Promiscuous mode (where RAT doesn't wait for an RTCP packet before
 allowing the source - i.e. it only requires a RTP packet and omits the
 'probation' check for in sequence RTP packets) has been on as default for
 a while as it useful for quickly connecting to devices that don't generate
 RTCP. However promiscuous mode is too relaxed about packet admission.
 Despite passing the rtp_validate() function some packets - especially
 those from a 'wrongly' (the key isn't correct) decrypted session - manage
 to pass that check but are actually garbage. The additional 'probation'
 checks in the promiscuous code (which checked for more than one packet in
 the sequence) are switched off.

 The fix is contained in the following changesets to RAT: r4121 and Common:
 r4122
  * Promiscuous mode has been disabled as default.
  * The wait_for_rtcp rtp option has been activated and added as a setting
 whose behaviour controls whether RAT waits for an RTCP packet before
 activating an RTP source. It's token has been renamed from
 RTP_OPT_WEAK_VALIDATION to RTP_OPT_WAIT_FOR_RTCP - It's value has been
 switched for previous usage as it makes more sense with the new naming.
  *  Basically the fixes lies in the changed default config: RAT now
 enabled wait_for_rtcp and disables promiscuous mode.

 Note: The values of rtpPromiscuousMode and rtpWaitForRTCP are not stored
 in the .RATdefaults/Win-registry - though they are read from the file.
 They are intended as advanced testing options.

-- 
Ticket URL: <https://frostie.cs.ucl.ac.uk/nets/mmedia/ticket/168>
Media Tools <http://www-mice.cs.ucl.ac.uk/multimedia/software>
Media Tools